Commit Graph

2065 Commits

Author SHA1 Message Date
ImaginalaticWizardry
6983fd0b17 Merge branch 'master' into pr/2612 2022-02-02 09:58:04 -07:00
Kai
2c0c34f10e
[Docs] HTTP => HTTPS 2022-01-16 14:25:11 +01:00
Jordan Harband
c2f740ab38
[patch] HTTP -> HTTPS 2022-01-18 12:49:57 -08:00
Jordan Harband
6cfaede5a0
[Fix] install: better error message when xcode command line tools are needed
Fixes #2697. Fixes #2663.
2021-11-27 22:16:14 -08:00
Luke Arms
1875fe8b40
[Fix] avoid OpenBSD nvm install error when /sbin/init doesn't exist
`nvm install` fails with "Binary download failed, trying source" when
- running on Bash;
- errtrace (`set -E`) is enabled;
- an ERR trap uses `exit` to return a non-zero status; and
- /sbin/init doesn't exist.

Resolved by moving `ls -dl /sbin/init` to the following `if` statement.
In this context, returning non-zero isn't an error and the ERR trap
isn't executed.
2021-12-26 15:31:53 +11:00
Luke Arms
81f0f3ec19
[Fix] set -E: Add test for node install on Bash with an ERR trap and set -E 2021-12-27 16:02:25 +11:00
lsfxz
fb4538b360
[Fix] add missing local (handle nonexisting /sbin/init a bit more cleanly) 2021-11-17 16:59:53 +01:00
Luke LaFountaine
d004c6b064
[readme] clarify instructions for running Node on M1 Mac 2021-12-03 16:52:18 -05:00
Bob Bregant II
79ad72d116
[Fix] Update nvm_extract_tarball to support OpenBSD
Fixes #2660.
2021-12-19 02:58:18 +00:00
Bob Bregant II
ccd442d833
[Refactor] add nvm_extract_tarball to consolidate extraction logic 2021-12-19 02:58:18 +00:00
Jordan Harband
9600617c52
v0.39.1 2021-12-17 14:55:52 -08:00
Jordan Harband
5cc74a6736
[Tests] fix failing test 2021-12-17 13:21:29 -08:00
Jordan Harband
aa57406ede
[Fix] ensure unload removes nvm_normalize_lts 2021-12-17 13:55:14 -08:00
Jordan Harband
0f62be6fdd
[Dev Deps] update markdown-link-check 2021-12-17 12:37:15 -08:00
Jordan Harband
c4c7690dec
[Fix] ls-remote/install: support lts/-X patterns in installs
Fixes #2692
2021-12-16 23:01:05 -08:00
Jordan Harband
aed1d732d7
[Fix] ls-remote/install: properly handle lts/x patterns 2021-12-16 22:58:06 -08:00
Jordan Harband
0b4cd8df6c
[Refactor] create nvm_normalize_lts helper 2021-12-16 22:55:02 -08:00
Jordan Harband
430860a8be
[Fix] nvm alias/nvm_list_aliases: support lts/ aliases
See #2692
2021-12-16 15:54:38 -08:00
Jordan Harband
2459d17741
[Tests] update test mocks 2021-12-16 23:13:15 -08:00
Varun Sharma
6cc90a4b8d
[actions] add step security runner 2021-11-22 07:20:50 -08:00
Jordan Harband
81fc05684d
[Tests] nvm_get_download_slug: add unit tests 2021-12-02 23:33:20 -08:00
Ankit Kumar
328dd5004e
[Fix] nvm_get_download_slug: better architecture selection for M1 Macs
If the node version is below 16.0.0 then nvm will select x86_64 architecture, else arm64 architecture.
2021-11-21 15:59:39 +05:30
Jérôme Foray
4856407d26
[Fix] install: fix method=script install condition
Fixes #2665; see 8937917
2021-11-30 16:07:22 +01:00
Jordan Harband
275001b066
[Tests] fix windows WSL tests 2021-11-25 19:35:39 -08:00
Jordan Harband
89379176ac
[Fix] install: properly check for curl/wget 2021-11-25 14:26:35 -08:00
Robert Elliot
30486b9bd9
[readme] Balance the if statement in bash example
Nesting the `elif` at the same level as the `if` and `fi` makes it clear which code applies to which branch (no .nvmrc file / found .nvmrc file).

I wasted a while looking at it trying to work out how it did anything if there was a .nvmrc file, because obviously the `if` didn't match and I couldn't see the `elif` branch.
2021-11-22 14:34:43 +00:00
Ian Grayson
e9b26938b9
[readme] Describe another failure case for installing node versions from source on mac arm64 machines.
It seems to be related to https://github.com/nodejs/node/issues/39313 (which describes a similar issue).
2021-11-15 04:23:42 -08:00
Jordan Harband
ccd98f7fcb
[Dev Deps] update doctoc 2021-11-19 08:59:37 -08:00
Jordan Harband
2f40eeef2e
[shellcheck] apply v0.8.0 updates 2021-11-19 08:53:43 -08:00
Nix
c9e7bb2da1
[Fix] install script: Add --no-pager option to git branch 2021-10-23 22:23:55 +09:00
Michal Stanke
3e631bcbd6 Update README.md 2021-09-29 08:09:34 +02:00
Michal Stanke
4bba7ea54c Change Ansible task to pass ansible-lint checks 2021-09-29 08:09:34 +02:00
Peter Dave Hello
7bbc57355d
[Tests] Print shell version in Travis CI 2017-04-02 07:33:49 +08:00
Alex Sabau
47f0b32155
[readme] Add info to restart bash if verification not working in verification section 2018-02-25 21:46:31 +01:00
James Stroud
91bd22aa57
[readme] fixed small typo afew to a few
also gave more up to date versions for example of  `nvm install` and `nvm which` as well as your pointer section
I love your project by the way.
2021-06-04 15:15:17 -04:00
Tim Connolly
ca897ac6d5
[readme] Avoid infinite loop in cdnvm() 2021-09-22 16:25:28 +10:00
Axel Svensson
11d71ab24b
[Fix] Regression in 2dad045
Fixes #2599
2021-09-24 01:56:47 +02:00
Georgi Chochov
4471b6beb6
[readme] remove duplicate word 'run' 2021-09-26 09:47:50 +00:00
Nikita N
cc6915e216
[readme] updated automatic call script for bash
Bash terminal was throwing error: `bash: cd: too many arguments` when directory had some spaces in the name.
The quotes around `$PWD` fixes this issue
2021-09-21 23:57:25 +03:00
Jordan Harband
b6b6e685a3
[Fix] set -a: when this option is set, some sh shells break
Fixes #2574
2021-09-14 23:26:31 -07:00
Gilad Barnea
d91087c333
[Fix] bash_completion: be robust when cd is overridden 2021-09-13 15:26:40 +03:00
Step Security
59532c74c6
[actions] restrict permissions for GITHUB_TOKEN 2021-09-10 06:09:45 +00:00
Jordan Harband
2dad0455ec
[Fix] nvm_die_on_prefix: avoid grepping env functions in bash
ironically, nvm itself has functions that matched this grep.
2021-09-08 23:49:16 -07:00
Jordan Harband
f03f69508e
[Fix] reinstall-packages: handle global symlink locations properly
This is a regression caused by npm ls -g in npm 7 no longer returning absolute paths.
2021-09-07 10:14:18 -07:00
Jordan Harband
fa63399991
[Tests] postcss v7.0.36 stopped working on node 0.10; downgrade to v4 2021-09-09 00:05:09 -07:00
Kevin Stolp
291c7c4c47
[Fix] nvm_ls_remote_index_tab: handle long version lists 2021-09-03 23:40:13 -07:00
Jordan Harband
c169d622ff
[Tests] update mocks 2021-09-04 08:57:36 -07:00
Jordan Harband
5b77f7d023
[Fix] nvm ls/nvm alias/nvm_list_aliases: zsh: when no LTS aliases, no error
Fixes #2575.
2021-09-01 10:06:32 -07:00
Jordan Harband
fd78c0101e
[Tests] disable fail-fast 2021-08-31 15:28:41 -07:00
Peter Dave Hello
678a827978 [Dockerfile] Update dated base image from Ubuntu 16.04 to 18.04 2021-08-31 02:03:30 +08:00