ld/yasnippet
1
0
Fork 0
mirror of https://github.com/joaotavora/yasnippet.git synced 2025-10-13 13:13:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Warn about backquote exprs modifying the buffer

Browse Source 
* yasnippet.el (yas--save-backquotes): Show a warning if evaluating the
backquote expression modifies the buffer.
This commit is contained in:
Noam Postavsky 2016-06-21 22:06:30 -04:00
parent ee4efdbbde
commit 85f39cec2b
1 changed files with 27 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
yasnippet.el
View File

@ -4017,20 +4017,33 @@ With optional string TEXT do it in string instead of the buffer."
(defun yas--save-backquotes () (defun yas--save-backquotes ()
"Save all the \"`(lisp-expression)`\"-style expressions "Save all the \"`(lisp-expression)`\"-style expressions
with their evaluated value into `yas--backquote-markers-and-strings'." with their evaluated value into `yas--backquote-markers-and-strings'."
(let* ((yas--change-detected nil)
(detect-change (lambda (_beg _end) (setq yas--change-detected t))))
(while (re-search-forward yas--backquote-lisp-expression-regexp nil t) (while (re-search-forward yas--backquote-lisp-expression-regexp nil t)
(let ((current-string (match-string-no-properties 1)) transformed) (let ((current-string (match-string-no-properties 1)) transformed)
(save-restriction (widen) (save-restriction (widen)
(delete-region (match-beginning 0) (match-end 0))) (delete-region (match-beginning 0) (match-end 0)))
(setq transformed (yas--eval-lisp (yas--read-lisp (yas--restore-escapes current-string '(?`))))) (let ((before-change-functions
(cons detect-change before-change-functions)))
(setq transformed (yas--eval-lisp (yas--read-lisp
(yas--restore-escapes
current-string '(?`))))))
(goto-char (match-beginning 0)) (goto-char (match-beginning 0))
(when transformed (when transformed
(let ((marker (make-marker))) (let ((marker (make-marker))
(before-change-functions (cdr before-change-functions)))
(save-restriction (save-restriction
(widen) (widen)
(insert "Y") ;; quite horrendous, I love it :) (insert "Y") ;; quite horrendous, I love it :)
(set-marker marker (point)) (set-marker marker (point))
(insert "Y")) (insert "Y"))
(push (cons marker transformed) yas--backquote-markers-and-strings)))))) (push (cons marker transformed) yas--backquote-markers-and-strings)))))
(when yas--change-detected
(lwarn '(yasnippet backquote-change) :warning
"`%s' modified buffer in a backquote expression."
(if yas--current-template
(yas--template-name yas--current-template)
"Snippet")))))
(defun yas--restore-backquotes () (defun yas--restore-backquotes ()
"Replace markers in `yas--backquote-markers-and-strings' with their values." "Replace markers in `yas--backquote-markers-and-strings' with their values."