Merge 387d92cd4d5b452175dd2df837f24adf25789331 into 6b70c40f151ca051d403453bf019e1707b33bd5b

[Fix] nvm_install_latest_npm: avoid unbound variable
Fixes #3447
2025-08-20 04:23:43 +00:00 · 2024-10-29 09:49:19 +01:00 · 2024-10-22 22:02:01 -07:00 · 2023-06-06 13:34:03 -04:00 · 2023-06-06 13:31:41 -04:00
1 changed files with 6 additions and 2 deletions
--- a/nvm.sh
+++ b/nvm.sh
@ -196,6 +196,9 @@ nvm_install_latest_npm() {
  nvm_echo 'Attempting to upgrade to the latest working version of npm...'
  local NODE_VERSION
  NODE_VERSION="$(nvm_strip_iojs_prefix "$(nvm_ls_current)")"
+  local NPM_VERSION
+  NPM_VERSION="$(npm --version 2>/dev/null)"
+
  if [ "${NODE_VERSION}" = 'system' ]; then
    NODE_VERSION="$(node --version)"
  elif [ "${NODE_VERSION}" = 'none' ]; then
@ -206,8 +209,6 @@ nvm_install_latest_npm() {
    nvm_err 'Unable to obtain node version.'
    return 1
  fi
-  local NPM_VERSION
-  NPM_VERSION="$(npm --version 2>/dev/null)"
  if [ -z "${NPM_VERSION}" ]; then
    nvm_err 'Unable to obtain npm version.'
    return 2
@ -3014,6 +3015,9 @@ nvm() {
      --) break ;;
      '-h'|'help'|'--help')
        NVM_NO_COLORS=""
+        if [[ "$NVM_NO_HELP" -eq 1 ]]; then
+          break;
+        fi
        for j in "$@"; do
          if [ "${j}" = '--no-colors' ]; then
            NVM_NO_COLORS="${j}"
Author	SHA1	Message	Date
Chris Seitz	edeed602d1	Merge 387d92cd4d5b452175dd2df837f24adf25789331 into 6b70c40f151ca051d403453bf019e1707b33bd5b	2024-10-29 09:49:19 +01:00
Jordan Harband	6b70c40f15	[Fix] `nvm_install_latest_npm`: avoid unbound variable Fixes #3447	2024-10-22 22:02:01 -07:00
Chris Seitz	387d92cd4d	Merge pull request #1 from cseitz-forks/cseitz-nvm-no-help-1 Added NVM_NO_HELP flag to nvm.sh	2023-06-06 13:34:03 -04:00
Chris Seitz	85e1d29fa8	Added NVM_NO_HELP flag to nvm.sh This allows you to prevent NVM from intercepting help calls.	2023-06-06 13:31:41 -04:00