Merge a99b8b0ca33f7d8a988cd3647c4e22dd86562025 into 74eb3960996576cd2f8ca8709574fc46e4c4f923

Let's say we have nvm installed in a separate mount, /.socket. NVM_DIR is $HOME/.nvm in /etc/profile.d/nvm.sh. With this setup, users can install Node versions to their home directories without each installing nvm.

nvm install --lts

This works fine as does nvm use --lts. When nvm exec is used though, it fails because it looks for nvm-exec in $NVM_DIR. First fix is to look for nvm-exec in $NVM_DIR. If NVM_DIR does not contain nvm-exec, check $BASH_SOURCE[0]. The second fix is to follow nvm-exec if a symbolic link to determine the proper location of nvm's home. Alternatively we could use a second environment variable, NVM_HOME in exec instead of relying on the directory name of nvm-exec.

.github/workflows/release.yml

@@ -19,6 +19,8 @@ jobs:
             raw.githubusercontent.com:443
             registry.npmjs.org:443
       - uses: actions/checkout@v4
+        with:
+          fetch-tags: true
       - uses: actions/setup-node@v4
         with:
           node-version: "14"

nvm-exec

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-DIR="$(command cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+DIR="$(dirname "$(realpath "${BASH_SOURCE[0]}")")"
 
 unset NVM_CD_FLAGS
 

nvm.sh

@@ -4075,8 +4075,14 @@ nvm() {
           nvm_echo "Running node ${VERSION}$(nvm use --silent "${VERSION}" && nvm_print_npm_version)"
         fi
       fi
-      NODE_VERSION="${VERSION}" "${NVM_DIR}/nvm-exec" "$@"
+
+      NVM_EXEC="${NVM_DIR}/nvm-exec"
+      if [ ! -f "${NVM_EXEC}" ]; then
+        NVM_EXEC="$(dirname "${BASH_SOURCE[0]-}")/nvm-exec"
+      fi
+      NODE_VERSION="${VERSION}" "${NVM_EXEC}" "$@"
     ;;
+
     "ls" | "list")
       local PATTERN
       local NVM_NO_COLORS

package.json

@@ -45,7 +45,7 @@
     "dockerfile_lint": "^0.3.4",
     "doctoc": "^2.2.1",
     "eclint": "^2.8.1",
-    "markdown-link-check": "^3.12.2",
+    "markdown-link-check": "^3.13.6",
     "replace": "^1.2.2",
     "semver": "^7.6.3",
     "urchin": "^0.0.5"

test/slow/nvm exec/Running 'nvm exec --lts' when NVM_DIR differs from nvm

@@ -0,0 +1,18 @@
+#!/bin/sh
+
+set -ex
+
+die () { echo "$@" ; exit 1; }
+
+INSTPATH="$(mktemp -p "$(pwd)" -d)"
+trap 'test ! -z "${INSTPATH-}" && test -d "$INSTPATH" && rm -rf "$INSTPATH"' EXIT
+declare -x NVM_DIR=$INSTPATH
+\. ../../../nvm.sh
+
+nvm install --lts || die 'nvm install --lts failed'
+nvm exec --lts npm --version || die "`nvm exec` failed to run"
+declare -x NODE_VERSION="$(nvm exec --lts --silent node --version)"
+
+ln -s ../../../../nvm-exec "$INSTPATH/nvm-exec" || die "failed to create a symlink to $INSTPATH/"
+"$INSTPATH/nvm-exec" npm ls > /dev/null || die "`nvm exec` failed to run using nvm-exec helper"
+

test/slow/nvm run/Running 'nvm run --silent' should work

@@ -0,0 +1,28 @@
+#!/bin/sh
+
+set -ex
+
+die () { echo "$@" ; exit 1; }
+
+. ../../../nvm.sh
+
+echo "0.10.7" > .nvmrc
+
+# Check nvm run without --silent
+OUTPUT="$(nvm run --version)"
+EXPECTED_OUTPUT="Found '${PWD}/.nvmrc' with version <0.10.7>
+Running node v0.10.7 (npm v1.2.21)
+v0.10.7"
+[ ">${OUTPUT}<" = ">${EXPECTED_OUTPUT}<" ] \
+  || die "\`nvm run\` failed to run; did not match with the .nvmrc version; got >${OUTPUT}<"
+
+OUTPUT="$(nvm run --silent --version)"
+EXPECTED_OUTPUT="v0.10.7"
+[ "${OUTPUT}" = "${EXPECTED_OUTPUT}" ] \
+  || die "\`nvm run --silent\` failed to run silently; expected no output, got >${OUTPUT}<"
+
+# Output shouldn't be silent if --silent flag is not at the third argument position
+OUTPUT="$(nvm run --version --silent)"
+EXPECTED_OUTPUT=""
+[ "${OUTPUT}" != "${EXPECTED_OUTPUT}" ] \
+  || die "\`nvm run --version --silent\` should not be silent; expected >${OUTPUT}<, got no output"