Commit Graph

1006 Commits

Author SHA1 Message Date
Jordan Harband
ef8fc9e0f6
Merge c8d70e07b7 into df84c77a81 2022-10-17 12:25:52 +03:00
epoweripione
fe6268c021
[Fix] nvm install error unknown condition: -ne
Fixes #2914

Co-authored-by: epoweripione <siyuwuxin@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
2022-10-15 20:25:52 +08:00
Jordan Harband
df01d81128
[Refactor] add nvm_wrap_with_color_code; allow no color code 2022-10-13 20:16:42 -07:00
Jordan Harband
0ccd099bff
v0.39.2 2022-10-13 16:25:25 -07:00
Jordan Harband
f062cca179
[Refactor] nvm install/nvm_install_default_packages: move "get" logic inside helper 2022-10-13 15:03:36 -07:00
Jordan Harband
71a73b17cf
[Fix] --help: proper default NVM_COLORS info 2022-10-13 13:34:43 -07:00
Jordan Harband
0ae8409f4f
[Fix] nvm install-latest-npm: ensure npm 9 does not install on unsupported nodes 2022-09-08 14:59:25 -07:00
ryenus
5e9791c4f8
[perf] nvm_print_versions: re-implement using awk
reducing `nvm ls-remote` from almost 20s to below 2s.

Signed-off-by: ryenus <ryenus@gmail.com>
2022-06-05 13:27:03 +08:00
Josh Kelley
c6269e0ac2
[Fix] Don't override Mac M1 architecture for node ^14.17
Fixes #2743

Co-authored-by: Josh Kelley <joshkel@gmail.com>
Co-authored-by: Raz Luvaton <16746759+rluvaton@users.noreply.github.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
2022-03-30 10:53:01 -04:00
Jordan Harband
a82edf40ba
[Robustness] avoid a clobbered ls
Fixes #2824
2022-06-02 12:25:55 -07:00
deepakchethan
9e884b8d7b
[Fix] nvm install: show proper version in .nvmrc install instructions 2022-03-22 18:58:18 +05:30
Jordan Harband
c2f740ab38
[patch] HTTP -> HTTPS 2022-01-18 12:49:57 -08:00
Luke Arms
1875fe8b40
[Fix] avoid OpenBSD nvm install error when /sbin/init doesn't exist
`nvm install` fails with "Binary download failed, trying source" when
- running on Bash;
- errtrace (`set -E`) is enabled;
- an ERR trap uses `exit` to return a non-zero status; and
- /sbin/init doesn't exist.

Resolved by moving `ls -dl /sbin/init` to the following `if` statement.
In this context, returning non-zero isn't an error and the ERR trap
isn't executed.
2021-12-26 15:31:53 +11:00
Luke Arms
81f0f3ec19
[Fix] set -E: Add test for node install on Bash with an ERR trap and set -E 2021-12-27 16:02:25 +11:00
lsfxz
fb4538b360
[Fix] add missing local (handle nonexisting /sbin/init a bit more cleanly) 2021-11-17 16:59:53 +01:00
Bob Bregant II
79ad72d116
[Fix] Update nvm_extract_tarball to support OpenBSD
Fixes #2660.
2021-12-19 02:58:18 +00:00
Bob Bregant II
ccd442d833
[Refactor] add nvm_extract_tarball to consolidate extraction logic 2021-12-19 02:58:18 +00:00
Jordan Harband
9600617c52
v0.39.1 2021-12-17 14:55:52 -08:00
Jordan Harband
aa57406ede
[Fix] ensure unload removes nvm_normalize_lts 2021-12-17 13:55:14 -08:00
Jordan Harband
c4c7690dec
[Fix] ls-remote/install: support lts/-X patterns in installs
Fixes #2692
2021-12-16 23:01:05 -08:00
Jordan Harband
aed1d732d7
[Fix] ls-remote/install: properly handle lts/x patterns 2021-12-16 22:58:06 -08:00
Jordan Harband
0b4cd8df6c
[Refactor] create nvm_normalize_lts helper 2021-12-16 22:55:02 -08:00
Jordan Harband
430860a8be
[Fix] nvm alias/nvm_list_aliases: support lts/ aliases
See #2692
2021-12-16 15:54:38 -08:00
Ankit Kumar
328dd5004e
[Fix] nvm_get_download_slug: better architecture selection for M1 Macs
If the node version is below 16.0.0 then nvm will select x86_64 architecture, else arm64 architecture.
2021-11-21 15:59:39 +05:30
Jordan Harband
2f40eeef2e
[shellcheck] apply v0.8.0 updates 2021-11-19 08:53:43 -08:00
Jordan Harband
c8d70e07b7
[Robustness] handle an overridden type
Fixes #2352
2020-11-21 13:33:12 -08:00
Rodrigo Espinosa de los Monteros
4da7f101a2
[Fix] nvm_alias: ensure lts/-1 returns the one before lts/*
Fixes #2461
2021-03-11 16:22:31 -05:00
Lukman
1081ed161b
[New] install: add parallel build support for openbsd
Co-authored-by: Lukman <lukmaan.me@gmail.com>
Co-authored-by: Sladyn Nunes <sladynnunes98@gmail.com>
2020-12-26 22:23:35 +05:30
Vesa Vilhonen
52f67b3677
[Fix] exec: -- should stop argument parsing
Co-authored-by: Vesa Vilhonen <vesa@vilhonen.com>
Co-authored-by: Sladyn Nunes <sladynnunes98@gmail.com>
2020-11-20 13:06:28 +02:00
Sladyn Nunes
4fdef427e4
[New] install: add -b flag to skip building from source
Fixes #2114.
2021-02-16 19:34:23 +05:30
nmarghetti
7f6c0c053a
[Refactor] add nvm_install_binary_extract 2021-01-02 00:03:24 +01:00
nmarghetti
d396181ffb
[Refactor] add nvm_get_artifact_compression 2021-01-02 00:03:24 +01:00
Brandon L. Reiss
3243f7a082
[Fix] Fix potential unbound var error on nvm install
Fixes #2420. When using `nvm install` with an already installed
version, Bash (and potentially other shells) may emit an unbound
variable error when `set -u` is set. The presence of the error depends
on specific shell versions, but appears to happen in MacOS 11.1 (Big
Sur) using a recent Bash version installed via Homebrew (as of this
writing).

The fix accesses `ALIAS` correctly for the case where it is not set by
an `alias` option to `nvm install`.
2021-01-27 13:12:17 -05:00
Hosam Aly
31c5c5c45a
[Fix] avoid parse error with common omz global aliases, in nvm_print_color_code
Fixes #2362. Fixes #2372.
2020-11-27 23:17:07 +00:00
Jordan Harband
436cda247e
[Fix] remove nvm_supports_source_options
Fixes #2387
2021-01-07 13:00:26 -08:00
Jordan Harband
3c079f16c7
[shellcheck] fix silly shellcheck complaint 2020-12-21 23:47:25 -08:00
Jordan Harband
e76b2945c5
[Fix] relax $PREFIX checking, to accomodate npm exec
Fixes #2379.
2020-12-21 23:03:30 -08:00
Keith Lazuka
86708833c9
[Fix] Use local variable when looping over args
When the `nvm` function is called by a script which itself uses a variable
named `i`, `nvm` clobbers the caller's variable. This happens even if the
caller has declared its variable as local.

See note 1 on https://tldp.org/LDP/abs/html/localvar.html#FTN.AEN18568
2020-12-08 12:28:24 -05:00
Jordan Harband
4b947ec92d
v0.37.2 2020-11-27 21:34:28 -08:00
Jordan Harband
3b57dfec8d
Revert "[Fix] nvm_die_on_prefix: only grep lines starting with env var name" (#2347)
This reverts commit 21c0c05130.

Fixes #2360. Fixes #2364. Fixes #2366.
2020-11-27 21:28:12 -08:00
Jordan Harband
661a702cdd
v0.37.1 2020-11-24 21:16:43 -08:00
Dena Burd
6848c16d53
[New] Added set-colors command. See details below:
This command allows users to replace default colors with their own custom colors.

 - top-level commands modified: alias, ls, ls-remote
 - helper functions added: nvm_echo_with_colors, nvm_err_with_colors,
nvm_set_colors, nvm_get_colors, nvm_print_color_code
 - functions modified: nvm_print_formatted_alias, nvm_print_versions, nvm_print_alias_path (implicitly), nvm_print_default_alias (implicitly), nvm_list_aliases (implicitly)

We added tests and info on using this command to the README!

Co-authored-by: Dena Burd <29719099+gitburd@users.noreply.github.com>
Co-authored-by: Naomi Quinones <52065567+naomiquinones@users.noreply.github.com>
2020-08-17 14:56:13 -07:00
Matteo De Wint
21c0c05130 [Fix] nvm_die_on_prefix: only grep lines starting with env var name 2020-11-16 11:35:26 +01:00
Jordan Harband
4054bd70ce
v0.37.0 2020-11-06 10:11:29 -08:00
Jordan Harband
499d303746
[Perf] use/nvm_die_on_prefix: replicate npm config algorithm and remove npm config call 2020-08-24 22:44:25 -07:00
Dena Burd
c72f2c6f21
[Fix] nvm ls-remote: accept versions that end with a dot
Fixes #983.
2020-09-24 13:46:29 -07:00
Dylan Armstrong
e01060fa2c
[Fix] nvm_die_on_prefix: use directory comparison rather than string 2020-10-09 09:43:21 -05:00
Dylan Armstrong
96069da0d5
[Fix] nvm_ls: zsh: unset markdirs and local_options
Fixes #2315.
2020-10-09 09:43:21 -05:00
Jordan Harband
7929190e6e
[Docs] improve nvm --help output
Fixes #2301
2020-10-02 22:22:12 -07:00
Jordan Harband
8debf39f24
v0.36.0 2020-09-23 16:18:37 -07:00