2223 Commits

Author SHA1 Message Date
Jordan Harband
ef3b20c21e
[readme] add logo 2022-04-22 16:53:49 -07:00
Dani Schuhman
01886b4243
[meta] Update CODE_OF_CONDUCT to current version 2022-04-15 10:56:26 -04:00
Jordan Harband
bd083ff367
[readme] minor cleanup 2022-04-11 14:09:37 -07:00
deepakchethan
9e884b8d7b
[Fix] nvm install: show proper version in .nvmrc install instructions 2022-03-22 18:58:18 +05:30
Ponder
7d86701067
[readme] fish: send output from load_nvm to /dev/stderr 2022-04-01 13:00:58 -04:00
legendecas
c367d7daa0
[Docs] fix fish load_nvm variable interpolations 2022-03-28 23:28:53 +08:00
Antony Tse
d157cac689
[readme] Correct typos in "Macs with M1 chip" section 2022-03-09 09:41:48 +00:00
Jordan Harband
39d9a42c35
[Fix] install.sh: error out if the install instructions are not followed 2022-02-08 10:40:11 -08:00
Kai
2c0c34f10e
[Docs] HTTP => HTTPS 2022-01-16 14:25:11 +01:00
Jordan Harband
c2f740ab38
[patch] HTTP -> HTTPS 2022-01-18 12:49:57 -08:00
Jordan Harband
6cfaede5a0
[Fix] install: better error message when xcode command line tools are needed
Fixes #2697. Fixes #2663.
2021-11-27 22:16:14 -08:00
Luke Arms
1875fe8b40
[Fix] avoid OpenBSD nvm install error when /sbin/init doesn't exist
`nvm install` fails with "Binary download failed, trying source" when
- running on Bash;
- errtrace (`set -E`) is enabled;
- an ERR trap uses `exit` to return a non-zero status; and
- /sbin/init doesn't exist.

Resolved by moving `ls -dl /sbin/init` to the following `if` statement.
In this context, returning non-zero isn't an error and the ERR trap
isn't executed.
2021-12-26 15:31:53 +11:00
Luke Arms
81f0f3ec19
[Fix] set -E: Add test for node install on Bash with an ERR trap and set -E 2021-12-27 16:02:25 +11:00
lsfxz
fb4538b360
[Fix] add missing local (handle nonexisting /sbin/init a bit more cleanly) 2021-11-17 16:59:53 +01:00
Luke LaFountaine
d004c6b064
[readme] clarify instructions for running Node on M1 Mac 2021-12-03 16:52:18 -05:00
Bob Bregant II
79ad72d116
[Fix] Update nvm_extract_tarball to support OpenBSD
Fixes #2660.
2021-12-19 02:58:18 +00:00
Bob Bregant II
ccd442d833
[Refactor] add nvm_extract_tarball to consolidate extraction logic 2021-12-19 02:58:18 +00:00
Jordan Harband
9600617c52
v0.39.1 v0.39.1 2021-12-17 14:55:52 -08:00
Jordan Harband
5cc74a6736
[Tests] fix failing test 2021-12-17 13:21:29 -08:00
Jordan Harband
aa57406ede
[Fix] ensure unload removes nvm_normalize_lts 2021-12-17 13:55:14 -08:00
Jordan Harband
0f62be6fdd
[Dev Deps] update markdown-link-check 2021-12-17 12:37:15 -08:00
Jordan Harband
c4c7690dec
[Fix] ls-remote/install: support lts/-X patterns in installs
Fixes #2692
2021-12-16 23:01:05 -08:00
Jordan Harband
aed1d732d7
[Fix] ls-remote/install: properly handle lts/x patterns 2021-12-16 22:58:06 -08:00
Jordan Harband
0b4cd8df6c
[Refactor] create nvm_normalize_lts helper 2021-12-16 22:55:02 -08:00
Jordan Harband
430860a8be
[Fix] nvm alias/nvm_list_aliases: support lts/ aliases
See #2692
2021-12-16 15:54:38 -08:00
Jordan Harband
2459d17741
[Tests] update test mocks 2021-12-16 23:13:15 -08:00
Varun Sharma
6cc90a4b8d
[actions] add step security runner 2021-11-22 07:20:50 -08:00
Jordan Harband
81fc05684d
[Tests] nvm_get_download_slug: add unit tests 2021-12-02 23:33:20 -08:00
Ankit Kumar
328dd5004e
[Fix] nvm_get_download_slug: better architecture selection for M1 Macs
If the node version is below 16.0.0 then nvm will select x86_64 architecture, else arm64 architecture.
2021-11-21 15:59:39 +05:30
Jérôme Foray
4856407d26
[Fix] install: fix method=script install condition
Fixes #2665; see 8937917
2021-11-30 16:07:22 +01:00
Jordan Harband
275001b066
[Tests] fix windows WSL tests 2021-11-25 19:35:39 -08:00
Jordan Harband
89379176ac
[Fix] install: properly check for curl/wget 2021-11-25 14:26:35 -08:00
Robert Elliot
30486b9bd9
[readme] Balance the if statement in bash example
Nesting the `elif` at the same level as the `if` and `fi` makes it clear which code applies to which branch (no .nvmrc file / found .nvmrc file).

I wasted a while looking at it trying to work out how it did anything if there was a .nvmrc file, because obviously the `if` didn't match and I couldn't see the `elif` branch.
2021-11-22 14:34:43 +00:00
Ian Grayson
e9b26938b9
[readme] Describe another failure case for installing node versions from source on mac arm64 machines.
It seems to be related to https://github.com/nodejs/node/issues/39313 (which describes a similar issue).
2021-11-15 04:23:42 -08:00
Jordan Harband
ccd98f7fcb
[Dev Deps] update doctoc 2021-11-19 08:59:37 -08:00
Jordan Harband
2f40eeef2e
[shellcheck] apply v0.8.0 updates 2021-11-19 08:53:43 -08:00
Nix
c9e7bb2da1
[Fix] install script: Add --no-pager option to git branch 2021-10-23 22:23:55 +09:00
Peter Dave Hello
e367533eb8
[Refactor] Reduce one more sed & pipe to speedup 2017-03-28 23:15:35 +08:00
Peter Dave Hello
6534568745 [Fix] Enhance nvm debug for different environments 2019-01-12 14:17:01 +08:00
Waldir Pimenta
13f3cdcdf7
README: clarify how to specify default packages 2019-01-11 10:42:33 +00:00
Jordan Harband
3d9c31d944
v0.34.0 v0.34.0 2019-01-07 23:01:16 -08:00
Jordan Harband
0acccb8a77
Merge pull request #1974 from valeriemettler/valeriemettler-patch-1
[Docs] Improve phrasing of 'nvm current'
2019-01-05 14:10:31 -08:00
Valerie Mettler
6354b170d7
Improve phrasing of 'nvm current'
To help beginners know that 'nvm current' is talking about node and not nvm.
2019-01-05 12:20:56 -08:00
Javier Infante
5e065ec026 [Docs] fixing cdnvm on .bashrc 2018-12-31 08:42:58 +01:00
Peter Dave Hello
206d503a21
[Docs] Improve indent of output block in GitHub Issue template 2018-12-26 03:46:13 +08:00
Jordan Harband
deb2a9b821
[Docs] fix eclint 2018-12-19 15:36:24 -08:00
Joel Parker Henderson
fb83eeb140
[Docs] Add Ansible task example
Add Ansible task example to show how to install nvm and update it.

Ansible is a systems administration tool.
See https://github.com/ansible/ansible

My personal experience of `nvm` is that installing via Ansible is good, and that a good example can help. This example took me about an hour to learn, so I'm hoping to save other people some time. This example is somewhat different than any others that I found on the web. There may be a better way to write it, and if so, please improve it.
2018-12-19 12:45:59 -08:00
Peter Dave Hello
14179bc8ce
[shellcheck] Use -n/-z instead of ! -z/! -n condition
https://github.com/koalaman/shellcheck/wiki/SC2236
2018-12-03 13:59:19 +08:00
Jordan Harband
153506c8da
[shellcheck] ignore SC2230 errors 2018-11-25 16:22:25 -08:00
Jordan Harband
c1150c41ab
[Tests] avoid using shopt in zsh 2018-11-26 11:18:11 -08:00