Commit Graph

2194 Commits

Author SHA1 Message Date
Matt Saladna
a082fe9d3d
Merge b4ee18be6a into 762f9ef9d1 2024-07-07 21:04:21 +09:00
Jordan Harband
762f9ef9d1
[Tests] only install python 2.7 if not already installed
See ee6f7667 / #3067
2024-07-06 10:29:55 -05:00
Jordan Harband
e597bb208e
[Tests] use a better JSON parsing implementation 2024-06-10 11:33:12 -07:00
Jordan Harband
aa427ad396
[Tests] ensure travis can access public repo submodules 2024-06-10 09:15:16 -07:00
Jordan Harband
c20db2ab86
[actions] improve default action permissions 2024-06-10 08:59:48 -07:00
Jordan Harband
29dce5edfd
[New] allow .nvmrc files to support comments
In theory, `npx nvmrc` can now be used to validate an `.nvmrc` file that `nvm` will support. Allowances have been made for future extensibility, and aliases may no longer contain a `#`.

Fixes #3336. Closes #2288.

Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
2024-06-07 10:13:00 -07:00
Jordan Harband
95081f0bc2
[readme] update CII badge URLs 2024-06-06 14:19:11 -07:00
Jordan Harband
1750b8d327
[actions] update vampire/setup-wsl action 2024-05-30 12:37:36 -07:00
Jordan Harband
97093dc1b3
[Dev Deps] update markdown-link-check, semver 2024-05-30 12:36:26 -07:00
Matt Saladna
b4ee18be6a
Partial reversion of nvm-sh/nvm#1517. Each alias lookup adds 8 to the pids.current bean counter resulting in 64+ concurrent tids (tasks, w/ threads) thus making it susceptible to hit pids.max. Once reached, subshell behavior is unexpected yielding "retry: Resource temporarily unavailable" errors until cgroup capacity is restored. 2024-03-16 12:26:55 -04:00
Jordan Harband
811c039e2b
[actions] finisher tweaks 2024-03-08 22:28:53 -08:00
Huy Z
294ff9e3aa
[readme] Fix uninstall instructions
`nvm unload` will unset NVM_DIR. So gotta save NVM_DIR first.
2024-02-13 03:39:07 -08:00
Raphael Boidol
c24c3134a7
[actions] update action versions to use node 20 2024-02-18 21:56:53 +01:00
Jordi Paris Ferrer
c82e7a6f62
Fix typo in WSL section of README
`u` -> `you`
2024-02-17 16:39:36 -08:00
jbidad
4e2a71ba9b
[Docs] add nvm unload to uninstall nvm instructions 2024-01-18 12:07:01 +03:30
Jordan Harband
6c9cd2f2d1
[security] fix typo in threat model 2023-12-15 09:46:35 -08:00
Matt Saladna
3b811237cb
Drop same-owner on extraction 2023-12-09 19:30:19 -05:00
Matt Saladna
ad4fa37deb
Add test for NVM_DIR outside nvm.sh
Fix symlink traversal
2023-12-09 19:26:17 -05:00
Matt Saladna
d956279e5a
shellcheck warnings 2023-12-09 19:26:17 -05:00
Matt Saladna
c18cbf4d25
Allow nvm-exec to be linked into individual .nvm directories for system-wide installs with a localized Nodes.
Let's say we have nvm installed in a separate mount, /.socket. NVM_DIR is $HOME/.nvm in /etc/profile.d/nvm.sh. With this setup, users can install Node versions to their home directories without each installing nvm.

nvm install --lts

This works fine as does nvm use --lts. When nvm exec is used though, it fails because it looks for nvm-exec in $NVM_DIR. First fix is to look for nvm-exec in $NVM_DIR. If NVM_DIR does not contain nvm-exec, check $BASH_SOURCE[0]. The second fix is to follow nvm-exec if a symbolic link to determine the proper location of nvm's home. Alternatively we could use a second environment variable, NVM_HOME in exec instead of relying on the directory name of nvm-exec.
2023-12-09 19:25:43 -05:00
Jordan Harband
bab86d5de5
v0.39.7 2023-12-05 21:50:27 -08:00
Jordan Harband
d86f270438
[Fix] use \hash instead of command hash for zsh
See #3239; Fixes #3247; Closes #3246
2023-12-05 21:48:51 -08:00
Jordan Harband
c73009f503
v0.39.6 2023-12-04 22:03:25 -08:00
Ben Wiley
7aee54b76c
[readme] reorganize “deeper shell integration” instructions 2017-06-29 14:23:03 -04:00
Chris Meyers
6262b5a666
[readme] rearrange install args 2023-10-23 21:48:11 -06:00
Ellet
925cff2c78
[readme] update M1 to “Apple Silicon” because of M2 and M3; fix typos 2023-12-01 05:56:48 +03:00
Jordan Harband
b1fa143dd8
[Fix] nvm_get_mirror: ensure only a valid URL is allowed 2023-12-02 14:44:46 -08:00
Jordan Harband
cc765cc000
[Fix] avoid overridden hash
Fixes #3239
2023-11-24 20:42:53 -08:00
Jordan Harband
99646ee600
[security] add threat model 2023-11-15 10:10:29 -08:00
Jordan Harband
b356fab4b4
[meta] fix gitattributes to properly recognize images as binary 2023-11-22 22:29:01 -08:00
Hao Cheng
064f2597d1
[readme] fix level of headings 2023-11-12 14:18:39 +01:00
Jordan Harband
6b15796f66
[Tests] temporarily allow cygwin tests to fail 2023-12-04 15:49:09 -08:00
Jordan Harband
3e51872b98
[Tests] temporarily allow WSL tests to fail
See https://github.com/Vampire/setup-wsl/issues/50 / https://github.com/actions/runner-images/discussions/8791
2023-12-04 13:06:24 -08:00
Jordan Harband
4bdd57ba0f
[Fix] install.sh: when NVM_INSTALL_GITHUB_REPO is set, issue a warning
This should only annoy those testing their PRs; real users should never set this env var
2023-11-02 21:10:09 -07:00
Jordan Harband
d02ddcac2c
[Fix] nvm_get_mirror: disallow some non-URL characters
This should be improved in the future, but is fine for now
2023-11-01 21:01:28 -07:00
Andrius Solopovas
ef7fc2f2c0
[Fix] nvm_get_arch: proper value for alpine linux 2023-09-30 23:54:11 +01:00
Jordan Harband
b64e5474ea
[Tests] ensure windows tests install a node that actually works
- disable failing Alpine tests
 - disable Ubuntu-18.04 tests on node 18+
 - add Ubuntu-20.04 tests
2023-11-01 16:12:12 -07:00
Jordan Harband
1f970ccb7a
[Fix] nvm_normalize_lts: switch from expr to case
avoids `expr: warning: ^lts/-[1-9][0-9]*: using ^ as the first character of a basic regular expression is not portable; it is ignored`
2023-11-01 12:24:29 -07:00
Jordan Harband
6743aef70c
[New] nvm_resolve_alias: only resolve one line of a multiline alias file 2023-10-23 14:41:14 -07:00
Jordan Harband
10cdda081f
[Tests] update test mocks (new LTS, iron) 2023-10-25 15:39:12 -07:00
Jordan Harband
8241287349
[New] aliases: skip leading blank lines in alias file 2023-10-23 14:06:19 -07:00
Jordan Harband
6aeab3349c
[Robustness] nvm_list_aliases: avoid overwritten sort 2023-10-23 14:05:37 -07:00
Jordan Harband
bfce5889f7
[Test] update test mocks 2023-10-23 14:53:39 -07:00
Justin Dhillon
fd412645ca
[readme] add section on bare nvm install 2023-10-23 10:25:26 -07:00
Jordan Harband
2426a0c4b2
[security] add prose explaining OpenSSF CII Best Practices badge results
Fixes https://github.com/openjs-foundation/security-collab-space/issues/35.
2023-10-20 15:58:27 -07:00
Michael Di Prisco
8a83b36688
[readme] missing parenthesis 2023-10-06 02:36:26 +02:00
Jordan Harband
414e8d426f
[Tests] switch cygwin mirror 2023-10-09 14:50:40 -07:00
zhangdiandian
1b102ab9a6
[Tests] fix filename typo
Signed-off-by: zhangdiandian <1635468471@qq.com>
2023-10-09 07:31:04 +00:00
Peter Dave Hello
d4a733e4d8
[Dockerfile] Remove apt src disabling, no longer needed 2023-09-19 20:03:01 +08:00
Nam
1de3333651
[Dockerfile] [Fix] add missing leading slash in path 2023-09-18 17:42:40 +07:00