Commit Graph

221 Commits

Author SHA1 Message Date
Will Papper
3cc9525dce
[Docs] [Fix] Set $NVM_DIR to ".nvm" instead of "nvm"
- Operating system and version: Mac OS X Mojave

- What happened? $NVM_DIR was set to nvm

- What did you expect to happen? $NVM_DIR should be set to .nvm
I added the following line from the README to my .zshrc:
```
export NVM_DIR="${XDG_CONFIG_HOME/:-$HOME/.}nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" # This loads nvm
```

I couldn't figure out why nvm wasn't loading, until I realized that
`echo NVM_DIR="${XDG_CONFIG_HOME/:-$HOME/.}nvm"` outputs `NVM_DIR=nvm`.

Changing the line to `export NVM_DIR="${XDG_CONFIG_HOME/:-$HOME/}.nvm"` fixed the problem. This outputs `NVM_DIR=.nvm` as expected. I tested this and the same behavior holds true in Bash as well.
2019-04-24 00:03:01 -07:00
Bastian Fuchs
45c1b84794
[Fix] Determine correct sub directory if XDG_CONFIG_HOME is set
With the environment variable XDG_CONFIG_HOME set, the installation
script uses the directory $XDG_CONFIG_HOME/nvm now. Before the change
the variable's value with "/nvm" cut off was used, which usually results
in an installation without any subdirectory.
2019-04-28 12:51:15 +02:00
Jordan Harband
e7a5b7992b
[meta] update repo links to point to org 2019-04-24 16:08:34 -07:00
Jordan Harband
a56c6f1485
tweak logic 2019-01-21 21:58:43 -08:00
Ahmed El Sayegh
703babe60a
[Fix] Make installation less restrictive when NVM_DIR is set 2019-01-21 02:15:02 +02:00
Jordan Harband
3d9c31d944
v0.34.0 2019-01-07 23:01:16 -08:00
Peter Dave Hello
14179bc8ce
[shellcheck] Use -n/-z instead of ! -z/! -n condition
https://github.com/koalaman/shellcheck/wiki/SC2236
2018-12-03 13:59:19 +08:00
Paul Nickerson
caf6208dbd
install.sh: Print an error and exit the script if $METHOD is set to something unexpected. 2018-10-02 13:46:26 -04:00
Erik Lilja
8542df4ac5
[New] add support for $XDG_CONFIG_HOME 2018-08-14 21:45:40 +02:00
Spike Grobstein
9854928ba9
[New] install.sh: allow user to explicitly opt out of nvm adding the source string
this is done by checking if the user supplies `PROFILE=/dev/null` when running `install.sh`, the `nvm_detect_profile` function will not output any strings, causing `nvm_do_install` to skip adding `SOURCE_STR`.
2018-05-03 08:22:07 -07:00
Jordan Harband
93990ab7da
v0.33.11 2018-04-25 13:25:35 -07:00
Jordan Harband
177a9673a7
v0.33.10 2018-04-24 22:08:51 -07:00
Jordan Harband
1b14e6b4d9
v0.33.9 2018-04-14 22:38:18 -07:00
Brian M. Jemilo II
8b71861d06
[Fix] install.sh: Detect profile with $BASH_VERSION and $ZSH_VERSION
Using `$(basename "/$SHELL")` to detect the shell would also choose bash on mac
2018-04-09 15:13:02 -05:00
Brian M. Jemilo II
68fe26a5e4
[Fix] Add autocompletion support to zsh
Fixes #1707.
2018-04-09 14:54:28 -05:00
Peter Dave Hello
37e0977e60
install.sh: Improve install.sh prompt output, add a newline 2018-04-10 15:53:33 +08:00
Jordan Harband
5fc8bd950d
Fix whitespace 2018-02-25 13:34:28 -08:00
Peter Dave Hello
f3076d14c9
[Fix] Add missing "command" prefixes for few commands 2018-02-20 04:05:47 +08:00
Paul Norman
d34bb3247d
install.sh: Don't give detached HEAD advice when installing 2018-01-10 13:21:27 -08:00
Jordan Harband
7cba6cd6d0
install.sh: detect a defined but nonexistent $NVM_DIR
(ref: #1700)
2018-01-06 09:34:11 -08:00
Peter Dave Hello
2a8a81da94 [Fix] ShellCheck SC1117 in nvm.sh & install.sh 2017-12-14 03:26:17 +08:00
Jordan Harband
7ad6d98ced
v0.33.8 2017-12-12 10:43:17 -08:00
Jordan Harband
65f0572bdc
v0.33.7
Fixes
 - fix unassigned variable (#1665, #1664)
 - Fix for $path used by zsh (#1669)
 - `set -u`: ensure `NVM_USE_OUTPUT` is always set (#1671)
 - `install.sh`: Fix a bug that block that installation of node in install.sh (#1676)
 - `nvm install-latest-npm`: fix node 4-4.6

Documentation
 - Make `nvm cache clear` message less ambiguous (#1644)
 - Added missing piece (#1658)
2017-12-08 21:21:42 -08:00
Ahmad Magdy
c7ac69bfbb Fix nvm_install_node function in install.sh script to not override the actual NODE_VERSION value 2017-11-30 14:47:42 +01:00
Jordan Harband
b546436113
v0.33.6 2017-10-23 23:53:26 -07:00
Peter Dave Hello
a461a0fffc [Fix] install.sh shouldn't use not existed $NVM_PROFILE 2017-10-04 10:10:47 +08:00
Jordan Harband
6597e11971
v0.33.5 2017-09-29 12:50:27 -04:00
Jordan Harband
d91b6197f3
v0.33.4 2017-09-04 22:59:50 -07:00
Jordan Harband
6f19babbff
v0.33.3 2017-09-03 12:46:59 -07:00
Jordan Harband
3e1b4591bd
[New] install.sh: install bash_completion via script method.
Fixes #1588.
2017-08-08 10:11:41 -07:00
Peter Dave Hello
248706d5f8
[New] Clean up git reflog history before git gc 2017-07-14 00:37:58 +08:00
Peter Dave Hello
38a568c9c9
[New] Add --auto to git gc to speed up install & upgrade 2017-07-11 09:19:02 +08:00
Peter Dave Hello
1e69c4c77d
[New] Speedup process to install nvm from git by dropping commit history 2017-04-02 15:49:01 +08:00
Jordan Harband
0a95e77000
v0.33.2 2017-04-26 00:50:33 -07:00
Peter Dave Hello
ec3ba1973a
[New] install.sh: Parallel script download jobs 2017-04-05 04:54:38 +08:00
Peter Dave Hello
e84bcaabdc
[Refactor] Improve profile detection in install script 2017-04-03 23:06:04 +08:00
Peter Dave Hello
3f5fd57881
[Refactor] Reduce a sed command with pipe 2017-04-05 04:58:34 +08:00
Peter Dave Hello
f524bcb973
[Fix] Correct indent in install.sh 2017-04-05 05:01:54 +08:00
Peter Dave Hello
6a3b1dd2c3 [New] Enable curl auto compression/decompression
Enable `--compressed` parameter on curl to automatically enable
compression on request content by sending coressponding header, if the
server side supports compression format like deflate or gzip, curl will
also decompress the content automatically, so there is no additional
works need to done manually on client side, but just enjoy the benifits
of bandwidth and time saving!

Take https://nodejs.org/dist/index.tab as an example which is last
modified on Tue, 14 Mar 2017 22:41:05 GMT, the compressed transmission
only take 4829 bytes howevet the not compressed on taks 48000 bytes,
which is about 10 times larger!

This feature can be traced back to Sep 3 2002, in curl commit:
 - 64bbe9dfaf

So should be supported on various versions widely.
2017-03-23 16:51:20 +08:00
Peter Dave Hello
911ff87601 [Fix] bash_completion source prompt, remove && 2017-03-15 14:34:28 +08:00
Peter Dave Hello
9593616b8c [Fix] NVM_PROFILE bash/zsh detection in installation 2017-03-15 14:34:28 +08:00
Jordan Harband
6669e91bd8
v0.33.1 2017-02-20 17:59:20 -08:00
Jordan Harband
6fc0241c21
[Fix] install.sh: only un-interpolate $HOME for the profile source string.
Fixes #1384.
2017-02-12 00:32:49 -08:00
Ryan Wheale
1b2305232f
[install script] Use $HOME variable in NVM_DIR 2017-01-12 10:55:56 -07:00
Jordan Harband
40e40975eb
v0.33.0 2016-12-29 21:22:13 -10:00
Peter Dave Hello
7ed1e71944
[Refactor] Add missing backslash for dots
Related: #1279, 2a2b8bd, cadbbce
2016-11-24 13:47:20 +08:00
Peter Dave Hello
1ffa41886a
[New] Install bash programmble completions automatically 2015-05-23 14:07:34 +08:00
Peter Dave Hello
fd33179119 Revert "Also run git gc after nvm upgraded"
This reverts commit ce7f6d6e52.
2016-11-14 06:19:29 +08:00
Qiangjun Ran
2a2b8bdeb3
[Robustness] use backslash when sourcing in case of overridden dot
Fixes #1278.
2016-11-03 23:44:20 -07:00
Peter Dave Hello
a458ccbb87 Retab tab to 4 spaces and use echo instead of cat in install.sh 2016-10-29 11:17:54 +08:00