Charlie Hileman
2fcf3030dc
Merge cf9beb7f86 into 74eb396099
2025-02-04 16:01:08 -08:00
Charlie Hileman
9222739d18
[Fix] nvm_tree_contains_path: handle symbolic links
...
Co-Authored-By: Charlie Hileman <aiquicorp@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
2020-01-08 12:06:49 -05:00
Nicolas signed-log FORMICHELLA
edacf8275e
[Fix] Remove unneeded call to ls in nvm_arch
...
Remove the call to `ls` that was used to determine the symlink
destination
Reasoning :
* `od` resolves symlink itself due to the use of `fopen`
* Prevent the behaviour of `od` which will hang if the filename is
empty (i.e. `/sbin/init` missing) as it will be waiting for `stdin`
compared to quitting with error if the file just doesn't exist
Fixes #3006
2023-01-22 11:48:59 +01:00
Jordan Harband
552db40622
v0.39.3
2022-12-23 12:57:56 -08:00
Jordan Harband
ac357c59ef
[Fix] nvm install-latest-npm: npm v6.14.18 can not be installed from npm < v4.4.4
2022-12-21 14:28:15 -08:00
Jordan Harband
abe5e30a9d
[shellcheck] remove duplicate function
2022-12-22 13:00:12 -08:00
Jordan Harband
1f4bb91ae6
[Fix] ensure this variable is bound
...
Fixes #2926
2022-10-26 10:12:06 -07:00
Jordan Harband
924d77cc90
[Fix] debug: correct mistaken -V to --version from #2922
2022-10-24 10:51:20 -07:00
ryenus
095a4ca655
[Fix] debug: awk: not an option: --version
...
On Debian, the default awk/mawk doesn't support the '--version' option;
instead there's mawk-specific '-W version'.
2022-10-21 16:48:00 +08:00
ryenus
9721791563
[Fix] grep: warning: stray \ before /
...
No need to escape the `/` char in a grep pattern.
This is to fix the below error when using newer grep with `nvm_command_info`
> $ nvm_command_info curl
> grep: warning: stray \ before /
> /usr/bin/curl
This happens with at least GNU grep 3.8 version.
2022-10-20 10:49:43 +08:00
ryenus
89d6cdd6cf
[Fix] improve backward compatibility for non-gnu awk
...
Adding function alen(arr) since length(arr) is GNU extension.
Fixes #2916
2022-10-18 11:25:12 +08:00
epoweripione
fe6268c021
[Fix] nvm install error unknown condition: -ne
...
Fixes #2914
Co-authored-by: epoweripione <siyuwuxin@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
2022-10-15 20:25:52 +08:00
Jordan Harband
df01d81128
[Refactor] add nvm_wrap_with_color_code; allow no color code
2022-10-13 20:16:42 -07:00
Jordan Harband
0ccd099bff
v0.39.2
2022-10-13 16:25:25 -07:00
Jordan Harband
f062cca179
[Refactor] nvm install/nvm_install_default_packages: move "get" logic inside helper
2022-10-13 15:03:36 -07:00
Jordan Harband
71a73b17cf
[Fix] --help: proper default NVM_COLORS info
2022-10-13 13:34:43 -07:00
Jordan Harband
0ae8409f4f
[Fix] nvm install-latest-npm: ensure npm 9 does not install on unsupported nodes
2022-09-08 14:59:25 -07:00
ryenus
5e9791c4f8
[perf] nvm_print_versions: re-implement using awk
...
reducing `nvm ls-remote` from almost 20s to below 2s.
Signed-off-by: ryenus <ryenus@gmail.com>
2022-06-05 13:27:03 +08:00
Josh Kelley
c6269e0ac2
[Fix] Don't override Mac M1 architecture for node ^14.17
...
Fixes #2743
Co-authored-by: Josh Kelley <joshkel@gmail.com>
Co-authored-by: Raz Luvaton <16746759+rluvaton@users.noreply.github.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
2022-03-30 10:53:01 -04:00
Jordan Harband
a82edf40ba
[Robustness] avoid a clobbered ls
...
Fixes #2824
2022-06-02 12:25:55 -07:00
deepakchethan
9e884b8d7b
[Fix] nvm install: show proper version in .nvmrc install instructions
2022-03-22 18:58:18 +05:30
Jordan Harband
c2f740ab38
[patch] HTTP -> HTTPS
2022-01-18 12:49:57 -08:00
Luke Arms
1875fe8b40
[Fix] avoid OpenBSD nvm install error when /sbin/init doesn't exist
...
`nvm install` fails with "Binary download failed, trying source" when
- running on Bash;
- errtrace (`set -E`) is enabled;
- an ERR trap uses `exit` to return a non-zero status; and
- /sbin/init doesn't exist.
Resolved by moving `ls -dl /sbin/init` to the following `if` statement.
In this context, returning non-zero isn't an error and the ERR trap
isn't executed.
2021-12-26 15:31:53 +11:00
Luke Arms
81f0f3ec19
[Fix] set -E: Add test for node install on Bash with an ERR trap and set -E
2021-12-27 16:02:25 +11:00
lsfxz
fb4538b360
[Fix] add missing local (handle nonexisting /sbin/init a bit more cleanly)
2021-11-17 16:59:53 +01:00
Bob Bregant II
79ad72d116
[Fix] Update nvm_extract_tarball to support OpenBSD
...
Fixes #2660 .
2021-12-19 02:58:18 +00:00
Bob Bregant II
ccd442d833
[Refactor] add nvm_extract_tarball to consolidate extraction logic
2021-12-19 02:58:18 +00:00
Jordan Harband
9600617c52
v0.39.1
2021-12-17 14:55:52 -08:00
Jordan Harband
aa57406ede
[Fix] ensure unload removes nvm_normalize_lts
2021-12-17 13:55:14 -08:00
Jordan Harband
c4c7690dec
[Fix] ls-remote/install: support lts/-X patterns in installs
...
Fixes #2692
2021-12-16 23:01:05 -08:00
Jordan Harband
aed1d732d7
[Fix] ls-remote/install: properly handle lts/x patterns
2021-12-16 22:58:06 -08:00
Jordan Harband
0b4cd8df6c
[Refactor] create nvm_normalize_lts helper
2021-12-16 22:55:02 -08:00
Jordan Harband
430860a8be
[Fix] nvm alias/nvm_list_aliases: support lts/ aliases
...
See #2692
2021-12-16 15:54:38 -08:00
Ankit Kumar
328dd5004e
[Fix] nvm_get_download_slug: better architecture selection for M1 Macs
...
If the node version is below 16.0.0 then nvm will select x86_64 architecture, else arm64 architecture.
2021-11-21 15:59:39 +05:30
Jordan Harband
2f40eeef2e
[shellcheck] apply v0.8.0 updates
2021-11-19 08:53:43 -08:00
Jordan Harband
19f452ba0f
[Fix] avoid bash-specific syntax
...
Fixes #3499
2024-12-19 22:21:09 -08:00
Jordan Harband
b9b0ea8020
[Fix] install-latest-npm: npm v11 is out
2024-12-16 10:03:18 -08:00
Jordan Harband
6b70c40f15
[Fix] nvm_install_latest_npm: avoid unbound variable
...
Fixes #3447
2024-10-22 22:02:01 -07:00
Reetik Rajan
5dc31ac51b
[patch] give a more helpful message when lts alias is mistakenly used
2024-10-05 09:21:42 +05:30
Jordan Harband
da2720a429
[Fix] nvm ls, nvm alias, nvm install: error when an LTS name is invalid
2024-09-04 13:55:11 -07:00
Jordan Harband
9fb9dec710
[Fix] nvm_normalize_lts: error when an LTS name is not lowercase
...
Fixes #3417
2024-09-04 13:54:41 -07:00
Jordan Harband
179d45050b
v0.40.1
2024-08-27 13:44:15 -07:00
Jordan Harband
ff7634577b
[Tests] fix broken tests exposed by 863bd63
...
Leaves 2 non-executable, + some TODOs
2024-08-27 12:46:40 -07:00
Jordan Harband
0ce8f5a52f
[Fix] nvm_download: ensure all args are quoted
...
Fixes #3411 .
2024-08-20 22:33:38 -07:00
Jordan Harband
df70535248
[Fix] nvm_auto: Fix bug introduced in c31a867
2024-08-21 10:54:19 -07:00
Jordan Harband
c31a867c46
[Fix] --save: avoid a conflict with set -e
...
Fixes #3405 .
2024-08-10 15:52:24 +12:00
Jordan Harband
a8c418558a
[Refactor] --save: clean up some usage
2024-08-20 16:21:45 -07:00
Jordan Harband
d5e2c92a25
[Fix] nvm_has_colors: avoid an aliased tput
...
Fixes #3413
2024-08-20 09:23:45 -07:00
Jordan Harband
4beab63631
[Fix] declare an unbound variable
...
Fixes #3402
2024-08-07 17:38:37 +12:00
Jordan Harband
14acd3dcdd
[Fix] nvm install -b: do not attempt to download source on a failed binary download with -b
...
Fixes #3399
2024-08-01 10:35:37 -07:00
