From 55ae1271b7ccafcb646400eb0f0cd1707b04f739 Mon Sep 17 00:00:00 2001
From: Peter Dave Hello <hsu@peterdavehello.org>
Date: Thu, 24 Nov 2016 16:16:54 +0800
Subject: [PATCH] [Tests] Create shellcheck.sh to handle shellcheck tests

This would make the shellcheck related process much more maintainable
and make .travis.yml simpler.
---
 .travis.yml   |  3 +--
 shellcheck.sh | 11 +++++++++++
 2 files changed, 12 insertions(+), 2 deletions(-)
 create mode 100755 shellcheck.sh

diff --git a/.travis.yml b/.travis.yml
index 85c77d4..b243645 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -25,8 +25,7 @@ install:
   - chmod +x /tmp/urchin/package/urchin
   - '[ -z "$WITHOUT_CURL" ] || sudo apt-get remove curl -y'
 script:
-  - if [ -n "${SHELLCHECK-}" ]; then shellcheck -s bash nvm.sh && shellcheck -s sh nvm.sh && shellcheck -s dash nvm.sh && shellcheck -s ksh nvm.sh && shellcheck -s bash install.sh ; fi
-  - if [ -z "${SHELLCHECK-}" ]; then make TEST_SUITE=$TEST_SUITE URCHIN=/tmp/urchin/package/urchin test-$SHELL ; fi
+  - if [ -n "${SHELLCHECK-}" ]; then ./shellcheck.sh ; else make TEST_SUITE=$TEST_SUITE URCHIN=/tmp/urchin/package/urchin test-$SHELL ; fi
 env:
   global:
     - CXX=g++-4.8
diff --git a/shellcheck.sh b/shellcheck.sh
new file mode 100755
index 0000000..a7e9839
--- /dev/null
+++ b/shellcheck.sh
@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+
+for shell in bash sh dash ksh
+do
+  shellcheck -s "${shell}" nvm.sh
+done
+
+for bash_script in install.sh
+do
+  shellcheck -s bash "${bash_script}"
+done