From 21016267e3c1ea37e680c3b4a1cb0f61bcac45f2 Mon Sep 17 00:00:00 2001 From: Peter Dave Hello Date: Mon, 14 Nov 2016 15:50:11 +0800 Subject: [PATCH 1/2] [Tests] Move shellcheck to CircleCI --- .travis.yml | 4 +--- circle.yml | 10 ++++++++++ 2 files changed, 11 insertions(+), 3 deletions(-) create mode 100644 circle.yml diff --git a/.travis.yml b/.travis.yml index 22786bf..f4276cb 100644 --- a/.travis.yml +++ b/.travis.yml @@ -33,8 +33,7 @@ install: - chmod +x /tmp/urchin/package/urchin - '[ -z "$WITHOUT_CURL" ] || sudo apt-get remove curl -y' script: - - if [ -n "${SHELLCHECK-}" ]; then shellcheck -s bash nvm.sh && shellcheck -s sh nvm.sh && shellcheck -s dash nvm.sh && shellcheck -s ksh nvm.sh && shellcheck -s bash install.sh ; fi - - if [ -z "${SHELLCHECK-}" ]; then make TEST_SUITE=$TEST_SUITE URCHIN=/tmp/urchin/package/urchin test-$SHELL ; fi + - make TEST_SUITE=$TEST_SUITE URCHIN=/tmp/urchin/package/urchin test-$SHELL env: global: - CXX=g++-4.8 @@ -42,7 +41,6 @@ env: - PATH=$(echo $PATH | sed 's/::/:/') - NVM_DIR="${TRAVIS_BUILD_DIR}" matrix: - - SHELLCHECK=true - SHELL=bash TEST_SUITE=install_script - SHELL=sh TEST_SUITE=fast - SHELL=dash TEST_SUITE=fast diff --git a/circle.yml b/circle.yml new file mode 100644 index 0000000..10a732d --- /dev/null +++ b/circle.yml @@ -0,0 +1,10 @@ +dependencies: + override: + - sudo ln -sf /home/ubuntu/.local/bin/shellcheck /usr/bin/shellcheck + - sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 575159689BEFB442 && echo 'deb http://download.fpcomplete.com/ubuntu precise main' | sudo tee /etc/apt/sources.list.d/fpco.list && sudo apt-get update && sudo apt-get install stack bc -y && stack setup && stack install ShellCheck && shellcheck --version + cache_directories: + - "~/.stack" + +test: + override: + - shellcheck -s bash nvm.sh && shellcheck -s sh nvm.sh && shellcheck -s dash nvm.sh && shellcheck -s ksh nvm.sh && shellcheck -s bash install.sh From b3671a95b9dc6e892943a4f646eb95a130af70ca Mon Sep 17 00:00:00 2001 From: Peter Dave Hello Date: Mon, 14 Nov 2016 18:36:41 +0800 Subject: [PATCH 2/2] [Doc] Update README.markdown for CircleCI badge --- README.markdown | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/README.markdown b/README.markdown index b53baeb..e1c8028 100644 --- a/README.markdown +++ b/README.markdown @@ -1,4 +1,7 @@ -# Node Version Manager [![Build Status](https://travis-ci.org/creationix/nvm.svg?branch=master)][3] ![nvm version](https://img.shields.io/badge/version-v0.32.1-yellow.svg) +# Node Version Manager +[![Build Status](https://travis-ci.org/creationix/nvm.svg?branch=master)][3] +[![Circle CI Build Status](https://img.shields.io/circleci/project/creationix/nvm/master.svg)][4] +![nvm version](https://img.shields.io/badge/version-v0.32.1-yellow.svg) ## Table of Contents @@ -468,5 +471,6 @@ If setting the `default` alias does not establish the node version in new shells [1]: https://github.com/creationix/nvm.git [2]: https://github.com/creationix/nvm/blob/v0.32.1/install.sh [3]: https://travis-ci.org/creationix/nvm +[4]: https://circleci.com/gh/creationix/nvm [Urchin]: https://github.com/scraperwiki/urchin [Fish]: http://fishshell.com