From 6b70c40f151ca051d403453bf019e1707b33bd5b Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Tue, 22 Oct 2024 22:02:01 -0700 Subject: [PATCH] [Fix] `nvm_install_latest_npm`: avoid unbound variable Fixes #3447 --- nvm.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/nvm.sh b/nvm.sh index aeab48b..ed0e0b3 100755 --- a/nvm.sh +++ b/nvm.sh @@ -196,6 +196,9 @@ nvm_install_latest_npm() { nvm_echo 'Attempting to upgrade to the latest working version of npm...' local NODE_VERSION NODE_VERSION="$(nvm_strip_iojs_prefix "$(nvm_ls_current)")" + local NPM_VERSION + NPM_VERSION="$(npm --version 2>/dev/null)" + if [ "${NODE_VERSION}" = 'system' ]; then NODE_VERSION="$(node --version)" elif [ "${NODE_VERSION}" = 'none' ]; then @@ -206,8 +209,6 @@ nvm_install_latest_npm() { nvm_err 'Unable to obtain node version.' return 1 fi - local NPM_VERSION - NPM_VERSION="$(npm --version 2>/dev/null)" if [ -z "${NPM_VERSION}" ]; then nvm_err 'Unable to obtain npm version.' return 2