ld/nvm
1
0
Fork 0
mirror of https://github.com/nvm-sh/nvm.git synced 2025-05-10 14:21:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Fix] set -u: Add default empty value for $NVM_NO_ALIAS

Browse Source 
Adds a default value for NVM_NO_ALIAS so that nvm ls does not error out when run
in a bash nounset/-u (no unset vars) environment.
This commit is contained in:
Sehrope Sarkuni 2019-05-14 08:31:24 -04:00 committed by Jordan Harband
parent 45c1b84794
commit 0b5bb5ccd8
No known key found for this signature in database
GPG Key ID: 64A196AEE0916D55
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nvm.sh
View File

@ -3161,7 +3161,7 @@ nvm() {
esac esac
shift shift
done done
if [ -n "${PATTERN-}" ] && [ -n "${NVM_NO_ALIAS}" ]; then if [ -n "${PATTERN-}" ] && [ -n "${NVM_NO_ALIAS-}" ]; then
nvm_err '`--no-alias` is not supported when a pattern is provided.' nvm_err '`--no-alias` is not supported when a pattern is provided.'
return 55 return 55
fi fi

23
test/fast/Listing versions/Running "nvm ls" with nounset should not fail. Executable file
View File

@ -0,0 +1,23 @@
#!/bin/sh
die () { echo "$@" ; exit 1; }
\. ../../../nvm.sh
\. ../../common.sh
make_fake_node v0.12.34 || die 'fake v0.12.34 could not be made'
# Enable no unset variable
set -u
# Try an alias that does not exist
output=$(nvm ls 99 2>&1 1>/dev/null || true)
test -z "${output}" || die "1: expected empty; got >${output}"
# Try a version that does not exist
output=$(nvm ls 0.12.00 2>&1 1>/dev/null || true)
test -z "${output}" || die "2: expected empty; got >${output}"
# Try a version that does exist
output=$(nvm ls 0.12.34 2>&1 1>/dev/null || true)
test -z "${output}" || die "3: expected empty; got >${output}"