* Fix issue #131

This issue would occur because the function was recieving a raw prefix
arg instead of a number. This commit fixes that.

* Fix issue with previous commit, add test cases
This commit is contained in:
jtamagnan 2016-04-27 22:33:15 -04:00 committed by Steve Purcell
parent da069c88e5
commit 6a62e60bf2
3 changed files with 17 additions and 3 deletions

View File

@ -16,4 +16,10 @@ Feature: Insert increasing letters
Given I have cursors at "text" in "This text contains the word text thrice (text)" Given I have cursors at "text" in "This text contains the word text thrice (text)"
When I press "C-u 2 5 H-3" When I press "C-u 2 5 H-3"
And I press "SPC" And I press "SPC"
Then I should see "This z text contains the word aa text thrice (ab text)" Then I should see "This z text contains the word aa text thrice (ab text)"
Scenario: Three cursors, a-b-c
Given I have cursors at "text" in "This text contains the word text thrice (text)"
When I press "C-u H-3"
And I press "SPC"
Then I should see "This e text contains the word f text thrice (g text)"

View File

@ -11,3 +11,9 @@ Feature: Insert increasing numbers
When I press "C-9 H-0" When I press "C-9 H-0"
And I press "SPC" And I press "SPC"
Then I should see "This 9 text contains the word 10 text thrice (11 text)" Then I should see "This 9 text contains the word 10 text thrice (11 text)"
Scenario: Three cursors, 9-10-11
Given I have cursors at "text" in "This text contains the word text thrice (text)"
When I press "C-u H-0"
And I press "SPC"
Then I should see "This 4 text contains the word 5 text thrice (6 text)"

View File

@ -33,7 +33,8 @@
(defun mc/insert-numbers (arg) (defun mc/insert-numbers (arg)
"Insert increasing numbers for each cursor, starting at 0 or ARG." "Insert increasing numbers for each cursor, starting at 0 or ARG."
(interactive "P") (interactive "P")
(setq mc--insert-numbers-number (or arg 0)) (setq mc--insert-numbers-number (or (and arg (prefix-numeric-value arg))
0))
(mc/for-each-cursor-ordered (mc/for-each-cursor-ordered
(mc/execute-command-for-fake-cursor 'mc--insert-number-and-increase cursor))) (mc/execute-command-for-fake-cursor 'mc--insert-number-and-increase cursor)))
@ -58,7 +59,8 @@
"Insert increasing letters for each cursor, starting at 0 or ARG. "Insert increasing letters for each cursor, starting at 0 or ARG.
Where letter[0]=a letter[2]=c letter[26]=aa" Where letter[0]=a letter[2]=c letter[26]=aa"
(interactive "P") (interactive "P")
(setq mc--insert-letters-number (or arg 0)) (setq mc--insert-letters-number (or (and arg (prefix-numeric-value arg))
0))
(mc/for-each-cursor-ordered (mc/for-each-cursor-ordered
(mc/execute-command-for-fake-cursor 'mc--insert-letter-and-increase cursor))) (mc/execute-command-for-fake-cursor 'mc--insert-letter-and-increase cursor)))